https://bugs.kde.org/show_bug.cgi?id=493687
Nate Graham <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Visual artifacts when using |No longer adjusting |a large enough font |GridUnit by the font size | |makes many layouts using it | |for hardcoded sizes be too | |small with a | |larger-than-default yet | |supported font size Component|general |general Assignee|[email protected] |[email protected] Version|6.1.5 |6.6.0 Ever confirmed|0 |1 Target Milestone|--- |Not decided Status|REPORTED |CONFIRMED Keywords| |regression CC| |[email protected], | |[email protected], | |[email protected] Product|systemsettings |frameworks-kirigami --- Comment #1 from Nate Graham <[email protected]> --- Definitely fallout from the GridUnit change. 13px font is within the supported range, so we should fix this. Possible fixes include: 1. For each affected layout, base sizes on layouts' implicit widths and heights instead of using hardcoded GridUnit values. 2. Introduce a new global value like "Kirigami.Units.fontSizeMultiplier" that's a multiple of the default font size (which in your case would work out to be 1.3) and then multiply all hardcoded widths and lengths by that. 3. Revert the GridUnit change. --- #1 is the best approach, but the most work, and also wouldn't fully solve the problem because in some places, we do actually just want a hardcoded size. #2 is less work but still a lot, and would get us back to basically what we had before, just with a more intuitive API. #3 Is the easiest. To be honest, I'm leaning towards #3. -- You are receiving this mail because: You are watching all bug changes.
