https://bugs.kde.org/show_bug.cgi?id=492557

Marco Martin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/kpackage/-/commit/cd
                   |                            |f14b11ef914e3304b0171b91a61
                   |                            |c2388d0b7ee

--- Comment #8 from Marco Martin <[email protected]> ---
Git commit cdf14b11ef914e3304b0171b91a61c2388d0b7ee by Marco Martin.
Committed on 27/09/2024 at 15:08.
Pushed by mart into branch 'master'.

Don't double emit emitResult()

setupNotificationsOnJobFinished connects to jobThreadFinished and in
there emitResult() is called, so avoid a second connection that would
lead to a double emitted signal.

connect to installPathChanged before connecting to jobThreadFinished.
Signal order matters here, as some client code relies that the package
path() to already be the final "correct" one when the job finishes

together with
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2535

M  +6    -6    src/kpackage/packagejob.cpp

https://invent.kde.org/frameworks/kpackage/-/commit/cdf14b11ef914e3304b0171b91a61c2388d0b7ee

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to