On Thursday 16 March 2006 12:46, Adriaan de Groot wrote:
> Well, since kdelibs builds with CMake just fine (see the dartboard for
> results), I figured it was time to try out kdebase. This is where one
> rapidly runs into the lack of canonical knowledge about CMake -- and a
> little laziness wrt. reading the entire CMake manual. Here's some comments
> based on current output (using CMake 2.3.3). Phrased in an unfriendly
> manner.
>
> Syntax error in cmake code at
> (no filename given):-1:
> syntax error, unexpected cal_SYMBOL, expecting cal_RCURLY (12), when

I think that error message can be improved. I started on 
mCommandArgumentParser.y, patch attached. Someone should give token display 
names for all tokens in all grammars(IMHO, AFAICT).

A cmake developer is perhaps lurking that can take care of it, or someone else 
that can ensure it gets the proper attention?


Cheers,

                Frans
Index: cmCommandArgumentParser.y
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/cmCommandArgumentParser.y,v
retrieving revision 1.4
diff -u -3 -p -r1.4 cmCommandArgumentParser.y
--- cmCommandArgumentParser.y	13 Jun 2005 14:27:05 -0000	1.4
+++ cmCommandArgumentParser.y	16 Mar 2006 13:21:47 -0000
@@ -76,13 +76,13 @@ static void cmCommandArgumentError(yysca
 /* Tokens */
 %token cal_NCURLY
 %token cal_DCURLY
-%token cal_DOLLAR
-%token cal_LCURLY
-%token cal_RCURLY
+%token cal_DOLLAR "$"
+%token cal_LCURLY "{"
+%token cal_RCURLY "}"
 %token cal_NAME
-%token cal_BSLASH
+%token cal_BSLASH "\\"
 %token cal_SYMBOL
-%token cal_AT
+%token cal_AT     "@"
 %token cal_ERROR
 %token cal_ATNAME
 
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to