Hi, On Friday 23 June 2006 14:44, you wrote: > Hi, > > Currently, FindQt4.cmake searches for "qmake" before "qmake-qt4". I think > that's wrong and that it should be reversed. > > Why: When qmake (from Qt3) and qmake-qt4 are in the $PATH, the check fails > unless the order is reversed. > > Why not: I can't see any reason why not. > > I'm asking because my commit r544680 was reversed by Alexander Neundorf in > r549218. I contacted him, but he wouldn't provide me with any > justification.
Privately or to kde-commits ? Please reply privately if it is important. > His commit message is as follows: > > "first check for qmake, then for qmake-qt4, this is in sync with cmake's > FindQt4.cmake and better for us (as we use qt-copy)" > > My rebuttal: > > 1) "In sync with cmake's FindQt4.cmake": Yes, that's why the fix should be > sent upstream. It's not a reason to preserve a bug. > > 2) "Better for us (as we use qt-copy)": I simply don't understand that > argument. If qmake-qt4 isn't found, it will look for qmake. So the one > residing in qt-copy would be used, and everyone is happy. No, not the people who have an up-to-date qt-copy qmake but an not-recent-enough qmake-qt4 from debian. Some people complained and will complain that qmake-qt4 is found although that one is from the installed Qt4 which is too old instead of the qmake installed from qt-copy which is always named qmake. > Alexander also provided the following suggestion: "consider adjusting PATH > or specifying QT4_QMAKE_EXECUTABLE directly." Adjusting PATH is not an > option because both qmake and qmake-qt4 live in /usr/bin on my system > (Debian). I tried specifying QT4_QMAKE_EXECUTABLE directly, but cmake > forgets the value when it is re-run automatically (for example, when you > modify a .cmake). This should not happen. The exact name is QT_QMAKE_EXECUTABLE, maybe it was just a typo on your side ? If nothing else helps, how about creating a directory qt4-bin/ in your home and put symlinks to the qt4-executables there and put this as the first directory in your path ? I really think there is no way to deal with all possible combinations of Qt3 qmake, Qt4 qmake, Qt4 qmake-qt4 and qt-copy qmake autmatically correct. Bye Alex -- Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de Home: neundorf AT kde.org - http://www.kde.org alex AT neundorf.net - http://www.neundorf.net _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
