On Monday 26 June 2006 21:46, Thiago Macieira wrote: > Alexander Neundorf wrote: > >Hi, > > > >in kdelibs the cmake module is named FindQtDBus.cmake, while all the > > variables it defines are named QDBUS_XXX (i.e. without the "t"). > > > >We should decide for one naming. > >Which one ? > > > >Thiago ? > > The naming is correct.
This depends on the definition of correct. All other cmake modules named FindFoo.cmake call their variables FOO_SOMETHING, as recommended in CMake/Modules/readme.txt: "Note to authors of FindXXX.cmake files We would like all FindXXX.cmake files to produce consistent variable names. Please use the following consistent variable names for general use. XXX_INCLUDE_DIR ... ... XXX_FOUND ... ... If you need other commands to do special things then it should still begin with XXX_. This gives a sort of namespace effect and keeps things tidy for the user. " So usually when using find_package(Foo) one expects that you can use FOO_LIBRARY, FOO_INCLUDE_DIR, FOO_FOUND etc. afterwards. > The module is named QtDBus (like QtCore, QtGui, QtXml, etc.), but > everything in it is QDBus*, qDBus or QDBUS_*. > > My advice is that you don't touch this code this week. Ok. Bye Alex -- Work: alexander.neundorf AT jenoptik.com - http://www.jenoptik-los.de Home: neundorf AT kde.org - http://www.kde.org alex AT neundorf.net - http://www.neundorf.net _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
