On Thursday 13 July 2006 13:22, Peter Kümmel wrote:
> SVN commit 561816 by kuemmel:
> 
> x11 version also compiles with msvc.
> Do we really need the _x11/_win versions?

I think so, for better integration with the native desktop.
Calling kfmclient is portable in itself, but don't you want that clicking on a 
link in kmail
opens the user-configured windows browser, e.g. IE [especially if kdebase isn't 
installed],
or vice-versa, clicking on a mailto: url in konqueror should launch the 
user-configured
email client (which is "kmail" by default in ktoolinvocation_x11.cpp, but 
should probably
use the windows API to find the user's mail client on windows)?

I think a lot more code can be factorized into ktoolinvocation.cpp, but there 
are still going
to be platform-specific parts in it.

In any case the stuff that talks to klauncher looks portable to me and should 
be moved to ktoolinvocation.cpp.
(all the start* methods)

-- 
David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to