On Thursday 11 January 2007 18:47, Alexander Neundorf wrote: > --- trunk/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #622372:622373 > @@ -627,19 +627,21 @@ > set(_type "GUI") > > # determine additional parameters for add_executable() > + # for GUI apps, create a bundle on OSX > if (APPLE) > set(_add_executable_param MACOSX_BUNDLE) > endif (APPLE) > > + # for GUI apps, this disables the additional console under Windows > + if (WIN32) > + set(_add_executable_param WIN32) > + endif (WIN32) > + > if (_nogui) > set(_type "NOGUI") > set(_add_executable_param) > - else (_nogui) > - if (WIN32) > - set(_add_executable_param WIN32) > - endif (WIN32) > endif (_nogui)
Why set something, and then (if nogui) unset it? Wouldn't it be more readable to do the gui stuff inside if(!_nogui)? -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
