On Thursday 04 October 2007 21:28:24 David Faure wrote:
> What do you think about this patch?

After tested compile of extragear/playground, I would like that you apply this 
patch.
I am ok with it.

> It reduces the debug output (and the time, a little bit) when configuring
> extragear from the toplevel. Because it's possible to configure it globally
> or each subdir separately, each subdir calls find_package(KDE4 REQUIRED) so
> the output looks like a large mess with the multiple lines of output
> related "looking for Qt4" and "looking for KDE4" repeated 9 times.
>
> KDE4_FOUND and QT4_FOUND don't go into the cache, so I think this change is
> correct, it only makes a difference when find_package is done multiple
> times. (Maybe cmake itself could remember the packages called, and notice
> "OK I have done find_package(KDE4 REQUIRED) already once, no need to do it
> again"?)
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to