On Wednesday 28 November 2007, Will Stephenson wrote:
> On Tuesday 27 November 2007 21:49:18 Will Stephenson wrote:
> > On Tuesday 27 November 2007 21:40:18 Alexander Neundorf wrote:
> > > On Tuesday 27 November 2007, Will Stephenson wrote:
> > > > Please review the attached patch, which adds a couple of functions to
> > > > MacroEnsureVersion.cmake to test whether a version number lies in a
> > > > given range.
> > > >
> > > > example: macro_ensure_version_range3( "0.6.5"
> > > > ${NETWORKMANAGER_VERSION} "0.7.0" NM_TOO_OLD NM_TOO_NEW )
> > > >
> > > > The macro_ensure_version_range2 works for versions of the form "x.y".
>
> Revised version
> *) drops the separate 2-part and 3-part dotted version number variants and
> uses a regexp to tell the difference internallyCool :-) > *) still uses 2 as the logarithm to partition major, minor, patch version > numbers - versions up to 99.99.99 work with this. Sure, somehow I saw a "1000" instead of a "10000" in your last patch (although it was also a 10000). > *) simplifies the success semantics to use a FOO_VERSION_OK set true on > success like MACRO_ENSURE_VERSION. - I didn't bother with the ARGN method Ok with me. > of including a variable args list. > *) Moves the documentation to the top of the file. I wasn't sure about the > right format so I imitated the other kdelibs cmake modules' documentation. Should be ok. I didn't actually test the patch, I guess you did :-) Did you also test weird stuff like maybe "3.4.1a" ? Bye Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
