Hi,
the attached patch makes the "interface" of FindFreetype.cmake compatible with
the interface of FindFreetype.cmake in cmake cvs (commit to cmake cvs will
follow) by adding the variable FREETYPE_INCLUDE_DIRS, which is set equal to
FREETYPE_INCLUDE_DIR.
I'd like to have that in 4.0 because this way KDE 4.0.x developers can use
the "API" of FindFreetype.cmake as it will be in cmake's version.
Having different interfaces to the same cmake module sucks, because it means
that
* once we require CMake 2.6 (maybe KDE 4.2) the FindFreetype module will only
provide FREETYPE_INCLUDE_DIRS, not FREETYPE_INCLUDE_DIR, so at this point in
time it would be a source incompatible change. Having _DIRS now in svn means
everybody should use the _DIRS variable already in KDE 4.0 and later on it
will just work.
* developers have to use them differently whether they are working in KDE or
outside KDE
Ok to commit ?
Alex
Index: FindFreetype.cmake
===================================================================
--- FindFreetype.cmake (revision 757142)
+++ FindFreetype.cmake (working copy)
@@ -2,9 +2,10 @@
# Once done this will define
#
# FREETYPE_FOUND - system has Freetype
-# FREETYPE_INCLUDE_DIR - the FREETYPE include directory
+# FREETYPE_INCLUDE_DIRS - the FREETYPE include directories
# FREETYPE_LIBRARIES - Link these to use FREETYPE
-#
+# FREETYPE_INCLUDE_DIR - internal
+
# Copyright (c) 2006, Laurent Montel, <[EMAIL PROTECTED]>
#
# Redistribution and use is allowed according to the terms of the BSD license.
@@ -69,3 +70,5 @@
ENDIF (FREETYPE_FOUND)
endif (FREETYPE_LIBRARIES AND FREETYPE_INCLUDE_DIR)
+
+set(FREETYPE_INCLUDE_DIRS ${FREETYPE_INCLUDE_DIR})
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
