On Tuesday 20 May 2008 11:09:19 Thiago Macieira wrote: > On Tuesday 20 May 2008 16:59:40 Allen Winter wrote: > > be extra careful about libICE and libSM prerequisites since many > > distros have separate development packages for these. > > > > --- trunk/KDE/kdelibs/cmake/modules/FindX11.cmake #810371:810372 > > @@ -295,6 +295,14 @@ > > SET(X11_SM_FOUND TRUE) > > ENDIF(X11_SM_LIB AND X11_SM_INCLUDE_PATH) > > > > + IF(NOT X11_ICE_FOUND) > > + MESSAGE(FATAL_ERROR "\nThe X11 Inter-Client Exchange (ICE) Library > > could not be found.\nCannot continue. Please install libICE.\n") + > > ENDIF(NOT X11_ICE_FOUND) > > + > > + IF(NOT X11_SM_FOUND) > > + MESSAGE(FATAL_ERROR "\nThe X11 Session Management (SM) Library could > > not be found.\nCannot contineu. Please install libSM.\n") + ENDIF(NOT > > X11_SM_FOUND) > > + > > # Deprecated variable for backwards compatibility with CMake 1.4 > > IF (X11_X11_INCLUDE_PATH AND X11_LIBRARIES) > > SET(X11_FOUND 1) > > I don't think FindX11.cmake is the place to put this. It should be in the > KDE code that requires X11 in the first place. In fact, it should be in the > code that requires ICE and/or SM, since other parts of KDE may be just fine > compiling with X11, but not those two. > I thought about that.. but SM is needed by kdeui/kernel/kapplication. And I don't see any point compiling KDE without it.
IOW: not having SM or ICE is like not having X11 at all... I think. But I probably should change things to simply set X11_FOUND to false when this condition arises. > PS: "continue" is misspelt in the second message I'll fix.
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
