On Friday 09 January 2009 2:47:30 pm Alexander Neundorf wrote: > On Friday 09 January 2009, Allen Winter wrote: > ... > > > We sure have a lot, don't we. > > ~90 FindFoo.cmake's in kdelibs > > > > I'm not sure I like your proposal, however. .. goes against our way of > > doing things. > > Yes, I know. > OTOH adding stuff to kdelibs is usually also not that easy, i.e. it happens > only after review and if it is documented, generally useful etc. > For the modules we don't do this yet.
I definitely agree that we should have tighter controls on stuff being added to kdelibs/cmake/modules. We should follow the same rules we follow for code. That should help a lot. kde-buildsystem review and approval should be a requirement before anything new goes in to kdelibs/cmake/modules. and ideally, patches should be reviewed first as well. > > > One day, all packages will provide their own FooConfig.cmake > > and then we won't have any individual maintenance at all :) > > Hmm, we have to keep them for all of KDE 4.x. > And "One day" is a long time from now. :) _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
