On Tuesday 03 February 2009, Orville Bennett wrote: > On Feb 2, 2009, at 1:40 PM, Alexander Neundorf wrote: > > On Sunday 01 February 2009, you wrote: > >> On Feb 1, 2009, at 4:52 PM, Alexander Neundorf wrote: > > > > ... > > > >>> If it's a bool value which goes into the cache I'd recommend using > >>> OPTION() > >>> instead of SET(). > >> > >> I just inserted APPLE in the WIN32 check and compilation worked. If > >> OPTION() is what should be used instead I can change it, but what > >> about the rest of the file? > > > > The set() -> option() change shouldn't affect the rest of the file > > > >>> But, maybe you can come up with some configure check which tests > >>> what is > >>> needed ? Maybe something with check_c_source_compiles() ? > >> > >> Nah, my cmake fu is still quite weak. I don't know enough to know how > >> to do that. > > > > If you can come up with a small file which builds in the one case > > but not in > > the other we can do this. > > Oh. Well when you put it like that it doesn't sound so hard :-) > I make no promises but i'll work on it. If too much time passes before > i get back to this poke me because I've probably forgotten. > In the mean time is
Ok. > > -if(WIN32) > > +if(APPLE OR WIN32) > > option (LIBZIP_COMPILED_WITH_32BIT_OFF_T OFF CACHE BOOL "Whether > > the system libzip library is compiled with 32bits off_t" ) > > -else(WIN32) > > +else(APPLE OR WIN32) > > option (LIBZIP_COMPILED_WITH_32BIT_OFF_T ON CACHE BOOL "Whether > > the > > system libzip library is compiled with 32bits off_t" ) > > -endif(WIN32) > > +endif(APPLE OR WIN32) > > Ok to commit to kdeutils-4.2.0/ark/plugins/libzipplugin/CMakeLists.txt ? Yes, I think so. Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
