Hi Helio, two weeks have almost passed, please have a look at the FindLibLZMA.cmake you committed and fix the issues listed below.
Alex On Wednesday 15 April 2009, Alexander Neundorf wrote: > Hi Helio, > > On Wednesday 15 April 2009, Helio Chissini de Castro wrote: > > SVN commit 954017 by helio: > > > > Add lzma/xz compression algorithm handling. > > Original code by Per Øyvind Karlsen, <[email protected]> > > Minor modifications bu Helio Castro <[email protected]> > > Reviewed by David Faure > > > > > > M +3 -0 CMakeLists.txt > > M +2 -0 ConfigureChecks.cmake > > A cmake/modules/FindLibLZMA.cmake > > Since a few weeks we have a commit policy for kdelibs/cmake/modules/: > http://techbase.kde.org/Policies/CMake_Commit_Policy > > You added a new cmake file, so this requires an explicit ok on the > buildsystem list. So we do that now. > > * FindLibLZMA.cmake works only if pkg-config is available. > Please change this so that it also works without pkg-config, but it's ok if > it prefers the information it gets from pkg-config if pkg-config is > successfull. Please also > > * Use a "PC_" prefix for the call to PKG_SEARCH_MODULE, so the variables > created by PKG_SEARCH_MODULE all have this prefix and don't get mixed up > with variables set via FIND_XXX(), see FindLibXml2.cmake as an example. > > * FIND_PACKAGE_HANDLE_STANDARD_ARGS() is used only in the Windows-branch, > why ? > > * Indentation in the IF(NOT WIN32) part is messed up. _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
