On Friday 24 July 2009, Sebastian Trüg wrote: > On Thursday 23 July 2009 23:33:58 Alexander Neundorf wrote: ... > > The attached patch doesn't change this, but it makes FindSoprano.cmake > > now also search the macros file and load it. This way the macro is > > automatically available if soprano has been found successfully. > > > > What do you think ? > > +1
Ok, committed. > but I am also open to fixing the issue in soprano directly and installing > the file in the correct folder. I only need to know which one it is exactly > since I obviously do not know. ;) Well, there is not really the "correct" one. Any directory which makes sense is good. It should be under share/, since the file is architecture independent. And I think it should be in a soprano-specific directory. Which gives <prefix>/share/soprano/cmake/. Since which version of soprano is that file installed ? IOW have there been already soprano releases which install this file to <prefix>/share/apps/cmake/modules/ ? If yes, then I think we have to be careful with changing the install location. If we would now just move the installed file from <prefix>/share/apps/cmake/modules/ to <prefix>/share/soprano/cmake/, then software which uses the "old" FindSoprano.cmake, let's call if kfoo, and which does include(SopranoAddOntology) will not build anymore (because previously the file has been more or less accidentially been found), but now, even though this is include() is not necessary anymore, it is still there in the CMakeLists.txt of kfoo and this include() will fail then. Is this something we have to care about ? Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
