Em Quarta-feira 2. Setembro 2009, às 03.42.41, Raphael Kubo da Costa escreveu: > Hi there, > > I don't think that piece of code has a proper maintainer, so I think > this mailing list is the most appropriate place to send this patch. > It's imported from FreeBSD, and makes libresolv optional when > detecting pciutils. > > I don't know the inner workings of pciutils or if KDE needs the > functionality provided by libresolv, but the patch itself looks OK. > > Any objections to committing (I haven't tested it on Linux myself)?
Yes.
Why don't systems build stuff properly? This is either a FreeBSD bug or an
upstream bug, so please take it there.
If libpciutils is a shared library, the .so files can contain dependencies. All
that it really needs is to add "-lresolv" to its own link command-line, if it
uses libresolv. It's quite simple: if you use it, you link to it.
If it's a static library, then it has to install a file that indicates how to
link to it and what its indirect dependencies are, like libtool's .la file or
pkg-config's .pc file. It just *has* to install this list because that's how
static libraries work.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Senior Product Manager - Nokia, Qt Development Frameworks
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14 San Francisco, California: Nov 2 - 4
http://qt.nokia.com/qtdevdays2009
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
