Am Mittwoch 21 Oktober 2009 01:23:26 schrieb Matthew Woehlke:
> Stefan Majewsky wrote:
> > Am Mittwoch 21 Oktober 2009 00:28:25 schrieb Parker Coates:
> >> I think a solution as was mentioned here would make sense for games in
> >> playground:
> >>
> >> http://markmail.org/message/s7bd2eaaqnm46vbv
> >>
> >> If Matthew's additions were surrounded by a guard as shown there, you
> >> could drop the dependence on the module while still doing the right
> >> thing when being built as part of the module. Of course if you'd
> >> rather keep your CMakeLists.txt clean, than I can understand that too.
> >
> > If the buildsystem guys agree with that solution (and they do
> > apparently), I'm fine with it too. Just one note on the patch: You can
> > remove the libkdegames stuff. I'm not depending on it.
> 
> Okay, so any objection if I commit this?
> 
> (Buildsystem folk, this is for playground/games/palapeli.)
> 
> Index: CMakeLists.txt
> ===================================================================
> --- CMakeLists.txt      (revision 1038078)
> +++ CMakeLists.txt      (working copy)
> @@ -1,5 +1,14 @@
>   project(palapeli)
> 
> +if (NOT KDE4_FOUND)
> [...]

I'm fine with it.

Greetings
Stefan

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to