2010/1/1 Michael Pyne <[email protected]>: > On Friday 01 January 2010 14:10:17 Pau Garcia i Quiles wrote: >> >> Till already defined _REENTRANT yesterday because he had the same >> >> problem in the MAC AFAIR. >> > >> > He's defined _REENTRANT inside an IF (APPLE) block. Should we move it >> > outside so that it's defined for all platforms? >> >> That'd be wrong IMHO. Shouldn't we check for the actual condition, >> then define _REENTRANT only if that condition is OK? > > Correctly multi-threaded code must be re-entrant by definition so it makes > sense to always define this as we want re-entrant versions of code whenever > the system libraries make it possible.
What you say would make sense if we wanted to *state* that our code is reentrant. But if I have understood correctly, what we are trying to do is *check* if the third-party libraries our libraries/applications use are reentrant. You cannot just say "sure, third-party is reentrant" because it might not be. -- Pau Garcia i Quiles http://www.elpauer.org (Due to my workload, I may need 10 days to answer) _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
