Hi Aurelien, On Sunday 25 April 2010, Aurélien Gâteau wrote: > SVN commit 1118756 by gateau: > > Added support for DBusMenu. > > M +2 -0 CMakeLists.txt > M +1 -0 cmake/modules/CMakeLists.txt > A cmake/modules/FindDBusMenuQt.cmake > M +2 -1 kdeui/CMakeLists.txt > M +34 -0 kdeui/notifications/kstatusnotifieritem.cpp > M +11 -0 kdeui/notifications/kstatusnotifieritemdbus_p.cpp > M +12 -0 kdeui/notifications/kstatusnotifieritemdbus_p.h > M +1 -0 kdeui/notifications/kstatusnotifieritemprivate_p.h > A kdeui/notifications/org.ayatana.dbusmenu.xml > M +1 -0 kdeui/notifications/org.kde.StatusNotifierItem.xml > > > --- trunk/KDE/kdelibs/CMakeLists.txt #1118755:1118756 > @@ -105,6 +105,8 @@ > macro_optional_find_package(QCA2) > macro_log_feature(QCA2_FOUND "QCA2" "Qt Cryptographic Architecture" > "http://delta.affinix.com/qca"; FALSE "2.0.0" "Needed for the plasma remote > widgets functionality.") > > +find_package(DBusMenuQt) > + > ################# Disallow in-source build ################# > > macro_ensure_out_of_source_build("kdelibs requires an out of source build. > Please create a separate build directory and run 'cmake path_to_kdelibs > [options]' there.") --- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt > #1118755:1118756 @@ -35,6 +35,7 @@ > FindBlueZ.cmake > FindBoost.cmake > FindCarbon.cmake > + FindDBusMenuQt.cmake > FindDNSSD.cmake > FindENCHANT.cmake > FindEigen.cmake
I assume you did not know that we have a commit policy for kdelibs/cmake/modules/: http://techbase.kde.org/Policies/CMake_Commit_Policy It says you *must* post a new file for review first and wait for a "Go". You did not do that. Please do it the next time. I had a quick look at the file, it seems to be ok. But one question: who are the current users of this file ? If it's only used inside kdelibs, it doesn't have to be installed. (each installed file has to be kept source compatible for the rest of KDE 4.x). Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
