Paulo Rômulo wrote: > Hello. > > I'm intending to add the attached file to kdelibs/cmake/modules in order > to conditionally build the Solid UPnP backend. This file tries to find the > HUPnP library on the system. Is everything ok with that? Can I commit?
I don't think that it is a good idea to mention why do we need a package in FindFoo.cmake. What if other package will find_package(HUpnp)? I think that "needed for Solid" should be moved to macro_log_feature after macro_optional_find_package(HUpnp). _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
