On Sunday 31 October 2010 13:34:41 Alexander Neundorf wrote: > On Sunday 31 October 2010, you wrote: > > On Sunday 31 October 2010 10:40:39 Alexander Neundorf wrote: > > > I think I'd like to propose that macro_log_feature() ignores the > > > REQUIRED keyword (we can't simply remove it due to compatibility > > > reasons) and that we use REQUIRED in the find_package() calls > > > instead. > > > > > > Pros: > > > - correct listing of all found and not-found packages by > > > FeatureSummary.cmake - cmake stops processing when something is > > > REQUIRED has not been found > > > > > > Cons: no summary of multiple missing required packages at the end of > > > the cmake run, only the last missing REQUIRED dependency will be > > > printed. > > > > > > Opinions ? > > > > IMO, the least we try outsmarting upstream, the better :) > > > > I just didn't understand the cons very well: if the last missing REQUIRED > > dependency will be printed out, does it mean that it will try to find all > > the required dependencies but only print the last one? > > No, the last == first == only failing find_package(.. REQUIRED) will > immediately result in a FATAL_ERROR, and cmake processing will stop there.
Ah, OK. Well, if there's not much we can do about that, "ship it" :) _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
