On Monday 11 July 2011, Michael Jansen wrote: > On Monday 11 July 2011 13:01:48 Stephen Kelly wrote: > > Volker Krause wrote: > > >> My idea would be something like that > > >> > > >> ECM_GET_VCS_VERSION( [DIRECTORY source_dir] ) > > >> > > >> Check in the directory for a .git dir -> git checkout -> try git svn > > >> info -> try some git log > > >> Check in the directory for a .svn dir -> try svn whatever > > >> Else: No version > > > > > > Sounds good, I hate copy/pasting this code all over the place (I also > > > need it in work projects) :) > > > > What do people think about trying to get stuff upstream to cmake before > > putting it in ecm? This vcs macro stuff looks universally useful. > > I personally gave up on trying to get stuff upstream. I just don't have > enough time for that and to many bad experiences. If there is no way i can > get it into a repository i control (have commit/push rights) i abstain > from doing it in the first place.
You can get commit/push right for cmake git, you just have to try hard enough. > But that is just me. I am willing to do the module. If someone else is > willing trying to get it upstream feel free. This does not work. If you write it, you maintain it. In CMake and ideally also here in KDE. Alex _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
