Hi,

* the file lacks documentation
* it mixes upper and lower case commands
* the IF(AKODE_LIBRARIES AND AKODE_INCLUDE_DIR) at the top is unnecessary and 
should be removed
* it doesn't use find_package_handle_standard_args()
* there's a comment #ensure that they are cached , but the code below doesn't 
do anything with the cache, so the include dir and library variables are not 
cached

So,
* where is FindAkode.cmake used ?
* any volunteers for making it nice ?

Alex
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to