Alexander Neundorf wrote:

> Hi,
> 
> same as with many others:
> 
> * unnecessary shortcut at the top
> * unnecessary if() around the pkgconfig stuff
> 
> Otherwise, it looks fine I'd say.
enchant installs its headers to $prefix/include/enchant by default. Thus the 
current code will not find enchant unless pkg-config information is 
available. Another question: should we force users to add 
$enchant_prefix/include/enchant to include_dirs(), or find_path( ... 
enchant/enchant++.h ...), and leave the decision whether to include 
$enchant_prefix/include or $enchant_prefix/include/enchant to the user?
-- 
Yury G. Kudryashov,
mailto: [email protected]

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to