Alexander Neundorf wrote: > Hi, > > this file looks quite ok. > > * it should use FPHSA() > * would simply find_file() calls also be good enough instead of > check_include_files() calls (which do try_compile() and so are slower) ? I'm going to submit another version to review this week-end. A few problems with current implementation:
* it calls check_include_files() which tries to compile a C (not C++) binary; this fails if acl.h contains a c++-style comment (i.e., if acl is not patched by distro). * No documentation for HAVE_* * Should set ACL_INCLUDE_DIRS, ATTR_INCLUDE_DIRS to $acl_prefix/include; $attr_prefix/include. * No documentation for ATTR_LIBS. -- Yury G. Kudryashov, mailto: [email protected] _______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
