> [: Yury G. Kudryashov :]
> Review the attached version of FindMsgfmt, please.
>   [...]
>   +  if(${_tmp} MATCHES "msgfmt \\(GNU gettext-tools\\) 
> ([0-9]+\\.[0-9]+\\.[0-9]+)\n")

I think this is a bit too specific check, and I know for a fact that minor
version number is not always present. I would use a more relaxed regex,
such as

  "msgfmt.* ([0-9]+\\.[0-9]+(\\.[0-9]+)?)"


-- 
Chusslove Illich (Часлав Илић)

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
  • FindMsgfmt Yury G. Kudryashov
    • Re: FindMsgfmt Chusslove Illich

Reply via email to