----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104619/#review12522 -----------------------------------------------------------
Looks fine to me; you might want to add the plasma group to the review request. CMakeLists.txt <http://git.reviewboard.kde.org/r/104619/#comment9813> I'd rephrase the description as "Needed to install the Plasma scriptengine for Python". - Raphael Kubo da Costa On April 16, 2012, 4:29 p.m., Michael Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104619/ > ----------------------------------------------------------- > > (Updated April 16, 2012, 4:29 p.m.) > > > Review request for Build System. > > > Description > ------- > > Remove checks for sip, pyqt4 and pykde4. They are unneeded. > > Correct fix for the given bug. > > BUG: 221501 > > > Diffs > ----- > > CMakeLists.txt 1385cb6a93568bb9c175a4c9d715e57cacb0f291 > plasma/generic/scriptengines/CMakeLists.txt > a157f437870c98194a9d7966bd7a227a68bd602f > > Diff: http://git.reviewboard.kde.org/r/104619/diff/ > > > Testing > ------- > > Reconfigured and compiled. > > > Thanks, > > Michael Jansen > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
