-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104698/#review13153
-----------------------------------------------------------


Can you please add an else() branch where it is set explicitely to 0 ?


- Alexander Neundorf


On April 23, 2012, 12:17 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104698/
> -----------------------------------------------------------
> 
> (Updated April 23, 2012, 12:17 p.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Xinerama libraries are currently only used by ksplash, and detection is 
> automagic.
> 
> This patch adds an option allowing compile without Xinerama even if it's 
> installed, defaulting to ON as to not change existing behaviour.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1385cb6a93568bb9c175a4c9d715e57cacb0f291 
>   ConfigureChecks.cmake ab4990f28f27748ff6c9fa8f1c0c9e46d17a9904 
> 
> Diff: http://git.reviewboard.kde.org/r/104698/diff/
> 
> 
> Testing
> -------
> 
> Configures and compiles fine, and scanelf reports Xinerama link when compiled 
> with -DWITH_XINERAMA=ON, and no link when off.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to