----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106101/#review17773 -----------------------------------------------------------
I don't really care, but I wouldn't add the quiet. The output may add useful information also in the case of failure. - Alexander Neundorf On Aug. 20, 2012, 3:22 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106101/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2012, 3:22 p.m.) > > > Review request for Build System and KDEPIM. > > > Description > ------- > > in case the package is not required, don't print a ton of debug output but > proceed quietly if it's not present. > > the fact that it's not found is already notified by the log anyway. > > > Diffs > ----- > > CMakeLists.txt d91ed8a > > Diff: http://git.reviewboard.kde.org/r/106101/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
