----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107148/ -----------------------------------------------------------
(Updated Nov. 2, 2012, 9:16 a.m.) Review request for Build System. Changes ------- Some more fixes along the way: - remove spurious dot from the byte-compiled file names - state which file is the destination byte-compiled one (like Python build tools do) Description ------- These adjustments ensure that the macros work with newer Python versions (which changed their behavior with byte-compiled files) and allow proper installation in systems where the name of the Python library is changed (see openSUSE). Additionally, all the finding logic is now delegated to the proper Find* packages in CMake. The variables are set to ensure source compatibility: those not set are directly taken from FindPythonInterp and FindPythonLibs. Additionally, PythonMacros is adjusted to ensure that Python files are properly byte-compiled and messages routed to the right place. This change will be committed only to the 4.10 branch, as it relies on some CMake functionality (VERSION_LESS, VERSION_GREATER, Python_ADDITIONAL_VERSIONS) only available in 2.8+. Note: I'm aware of the whitespace issues, will clean up before committing. Diffs (updated) ----- cmake/modules/FindPythonLibrary.cmake 60567e297f686ecc1a1c1f4bcebfd94181bfe116 cmake/modules/PythonMacros.cmake 661e32d0c8fbc5a083fd7e8271557ae51c5e12d1 Diff: http://git.reviewboard.kde.org/r/107148/diff/ Testing ------- Ran CMake in the PyKDE4 checkout, testing different interpreters and site-packages directories, no issues. Tested with a custom PyKDE4 project, no issues with file compilation. Thanks, Luca Beltrame
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
