Hi, On Thu, Dec 20, 2012 at 1:11 AM, Ben Cooksley <bcooks...@kde.org> wrote: > Git commit f9ea1c7b4fb351a4da16b386c23f15d6c109728a by Ben Cooksley. > Committed on 20/12/2012 at 01:11. > Pushed by bcooksley into branch 'master'. > > Interim hack to make everything which depends on kdepimlibs build again. > A proper solution is needed from the CMake folks, but I don't see consensus > on that.
FWIW, I think the change you comitted is almost the right fix, you forgot a REQUIRED there to ensure that finding kdepimlibs fails if nepomuk is not found. If kdepimlibs libraries expose Nepomuk API in their own public API then its a dependency of kdepimlibs, this is expressed by having nepomuk in the link-interface of the kdepimlibs libraries. Dependencies have to be searched and found before setting up ones own targets and their link-interfaces, so doing that in the config file is just fine. Andreas > CCMAIL: kde-buildsystem@kde.org > CCMAIL: kde-...@kde.org > > M +2 -0 KdepimLibsConfig.cmake.in > > http://commits.kde.org/kdepimlibs/f9ea1c7b4fb351a4da16b386c23f15d6c109728a > > diff --git a/KdepimLibsConfig.cmake.in b/KdepimLibsConfig.cmake.in > index e4c3ee1..41dc802 100644 > --- a/KdepimLibsConfig.cmake.in > +++ b/KdepimLibsConfig.cmake.in > @@ -1,5 +1,7 @@ > # KdepimLibs.cmake is generated by CMake from kdepimlibs/KdepimLibs.cmake.in > > +find_package(NepomukCore) > + > # set the kdepimlibs version number > set(KDEPIMLIBS_VERSION_MAJOR @KDEPIMLIBS_VERSION_MAJOR@) > set(KDEPIMLIBS_VERSION_MINOR @KDEPIMLIBS_VERSION_MINOR@) > _______________________________________________ > Kde-buildsystem mailing list > Kde-buildsystem@kde.org > https://mail.kde.org/mailman/listinfo/kde-buildsystem _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem