-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108516/
-----------------------------------------------------------

(Updated Jan. 22, 2013, 7:28 p.m.)


Review request for Build System, Release Team, Christophe Giboudeaux, Kevin 
Kofler, and Luca Beltrame.


Description
-------

Do not hardcode site-packages for the python libdir.


Diffs
-----

  cmake/modules/FindPythonLibrary.cmake 
7cef79b16521c759f38f1deea539a28a50c5d708 

Diff: http://git.reviewboard.kde.org/r/108516/diff/


Testing
-------

Not much. Works the same as before. Need someone to check on debian. Need 
someone to check when installing into /usr.

I think the strequal to check if PYTHON_SITE_PACKAGES_INSTALL_DIR is different 
from PYTHON_SITE_PACKAGES_DIR is not optimal but good enough. The only problem 
could be a trailing slash or different case on windows. Any hints to improve it?


Thanks,

Michael Jansen

_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem

Reply via email to