> On Feb. 14, 2013, 6:12 p.m., Alexander Neundorf wrote:
> > As long as e-c-m is not released yet, there is still time for source
> > incompatible changes.
> > But please list them here:
> > http://techbase.kde.org/Development/ECM_SourceIncompatChanges
> >
We missed one point: FPHSA sets ${UPCASE_NAME}_FOUND, not ${NAME}_FOUND. BTW,
are there any plans to change this (say, set both variables)?
- Yury Georgievich
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108954/#review27460
-----------------------------------------------------------
On Feb. 14, 2013, 9:44 a.m., Yury Georgievich Kudryashov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108954/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 9:44 a.m.)
>
>
> Review request for Build System.
>
>
> Description
> -------
>
> Fix FindLibUSB1
>
> - set properties on LibUSB1, not USB1
> - use LibUSB1_ prefix, not LIBUSB1_
>
> Do we care about compatibility? If yes, we should set LIBUSB1_* variables as
> well.
>
>
> Diffs
> -----
>
> find-modules/FindLibUSB1.cmake 100426ec606ff022526168d039dde65bccd808c1
>
> Diff: http://git.reviewboard.kde.org/r/108954/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yury Georgievich Kudryashov
>
>
_______________________________________________
Kde-buildsystem mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-buildsystem
