----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112136/#review38264 -----------------------------------------------------------
This review has been submitted with commit ecb29b6ca2b31ba6a7296ab325597a325806ab56 by Raphael Kubo da Costa to branch master. - Commit Hook On Aug. 17, 2013, 10:31 p.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112136/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2013, 10:31 p.m.) > > > Review request for Build System, Milian Wolff and Alexander Neundorf. > > > Description > ------- > > Add a separate block for clang definitions. > > Sharing compiler settings between GCC and clang does not always work: there > are flags (such as "-fno-check-new" or "-fno-reorder-blocks") that are > specific to GCC, and nothing stops these incompatibilities from becoming > bigger in the future. > > Conversely, a separate clang block allows us to pass some additional flags > to clang that would have required yet another if() in the GCC block. For > now, this amounts to "-fdelayed-template-parsing". > > (For KDE4, we also need -Wno-return-type-c-linkage because kdepim's > ktexteditorkabcbridge.cpp exports a function that returns a QString with C > linkage, but I hope this can be solved in a different way for kdepim5). > > Last but not least, checks for bad GCC allocators or support for some flags > which are always present in clang can be avoided altogether when we know the > compiler we are using. > > > Diffs > ----- > > kde-modules/KDECompilerSettings.cmake > 4a9f760b971870c8963cb43bf1b13599ff39a265 > > Diff: http://git.reviewboard.kde.org/r/112136/diff/ > > > Testing > ------- > > > Thanks, > > Raphael Kubo da Costa > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
