----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112137/#review38266 -----------------------------------------------------------
This review has been submitted with commit 90cb7ba760584a8010afef65fa14e649195af6c6 by Raphael Kubo da Costa to branch KDE/4.11. - Commit Hook On Aug. 17, 2013, 11:37 p.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112137/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2013, 11:37 p.m.) > > > Review request for Build System and Alexander Neundorf. > > > Description > ------- > > Sharing compiler settings between GCC and clang does not always work: there > are flags (such as "-fno-check-new" or "-fno-reorder-blocks") that are > specific to GCC, and nothing stops these incompatibilities from becoming > bigger in the future. > > Conversely, a separate clang block allows us to pass some additional flags > to clang that would have required yet another if() in the GCC block: > > o -fdelayed-template-parsing, needed for clang not to complain when we > build with exceptions disabled and include code that throws exceptions in > template code we do not instantiate. > > o -Wno-return-type-c-linkage, needed at least in kdepim because one of its > plugins exports a function with C linkage that returns a QString. > > Last but not least, checks for bad GCC allocators or support for some flags > which are always present in clang can be avoided altogether when we know the > compiler we are using. > > > This addresses bug 323579. > http://bugs.kde.org/show_bug.cgi?id=323579 > > > Diffs > ----- > > cmake/modules/FindKDE4Internal.cmake > 2449bf41785f76061447d48176dd11e9e7190a07 > > Diff: http://git.reviewboard.kde.org/r/112137/diff/ > > > Testing > ------- > > This is basically the upstreaming of what FreeBSD has been shipping locally > for quite a while. I've also been using this to build KDE from git for many > months without problems. > > > Thanks, > > Raphael Kubo da Costa > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
