----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110319/#review38508 -----------------------------------------------------------
What happened to this? - Nicolás Alvarez On May 6, 2013, 1:24 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110319/ > ----------------------------------------------------------- > > (Updated May 6, 2013, 1:24 p.m.) > > > Review request for Build System, Aleix Pol Gonzalez and Aaron J. Seigo. > > > Description > ------- > > replace finder script with cmake config making stuff scale > > it would be cool if someone from kde-buildsystem could check that > everything is in order. > > installing a finder yourself makes next to no sense considering cmake > configs do the same thing and do it better. > in particular the finder was installed into cmakedatadir/... which is not > searched by default (at least not by kde applications if kdedatadir != > cmakedatadir, e.g. on debian /usr/share vs. /usr/share/kde4). > I retained the BODEGA naming but I think one should think about changing > it > to Bodega as that looks rather a lot less silly. > > > Diffs > ----- > > CMakeLists.txt 97d1628c0af0ba3276699da20ce307ca22dde95f > lib/CMakeLists.txt 381c03f7e26adf95991bf020f214fbebd2060a6f > lib/bodega/CMakeLists.txt 1ecc498b494bdff8a75a3a4c49c61f4cdb66ccc4 > lib/cmake/BODEGAConfig.cmake.in PRE-CREATION > lib/cmake/CMakeLists.txt PRE-CREATION > lib/cmake/modules/CMakeLists.txt 0207620331bbf949018076ee526010443e6a3173 > lib/cmake/modules/FindBODEGA.cmake e4c69eec793ef4a7a9728241345c2d1cf9053fac > > Diff: http://git.reviewboard.kde.org/r/110319/diff/ > > > Testing > ------- > > found by muon and muon's backend builds > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
