> On Sept. 9, 2013, 4:13 p.m., Rex Dieter wrote: > > Here's a version I submitted while back (over a year ago now), > > https://git.reviewboard.kde.org/r/106861
Hi Rex, Thank you for the link! However, that seems even more wrong to me since you set a fixed version as prefix (samba-4.0). I really think it's better to just use pkgconfig in that case and let that app figure out the paths (like in my proposal). - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112448/#review39656 ----------------------------------------------------------- On Sept. 2, 2013, 1:04 p.m., Mark Gaiser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112448/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 1:04 p.m.) > > > Review request for Build System. > > > Description > ------- > > FindSamba couldn't find samba on my machine. Perhaps because it's Samba 4 and > it's include folder is /usr/include/samba-4.0/. However, "pkg-config > --cflags-only-I smbclient" worked just fine and returned the correct include > path. This patch falls back to pkg-config if it couldn't find samba. > > > Diffs > ----- > > cmake/modules/FindSamba.cmake c4df80f > > Diff: http://git.reviewboard.kde.org/r/112448/diff/ > > > Testing > ------- > > Works, finds samba without issues. > > > Thanks, > > Mark Gaiser > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
