> On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 29 > > <http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line29> > > > > This variable shouldn't be needed at all.
Variable? Or argument? Why? > On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 32 > > <http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line32> > > > > I recommend not putting this in the API of the function, and instead > > users should use > > > > install(DIRECTORY) to install the generated files. Why? > On Oct. 24, 2013, 1:54 p.m., Stephen Kelly wrote: > > modules/ECMGenerateHeaders.cmake, line 11 > > <http://git.reviewboard.kde.org/r/113406/diff/2/?file=205462#file205462line11> > > > > I really think the answers to my questions here need to be found first: > > > > http://thread.gmane.org/gmane.comp.kde.cvs/1272841 > > > > It should be more-simple than it currently is. I think that this patch answers most of these questions, leaving up to discussion if we expect people to include "module/something.h" or just "something.h". I'd say that if Qt5 transition teaches something is that it's not very flexible to namespace the include files, but that's up to the developer anyway... - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42280 ----------------------------------------------------------- On Oct. 24, 2013, 1:40 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113406/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 1:40 p.m.) > > > Review request for Build System, KDE Frameworks and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > Create a macro that will generate the forward headers like we used to, in > cmake configure time. > > Here's an example of how we'd port KParts to that macro: > http://paste.opensuse.org/9880051 > After the change, these are the installed headers: > http://paste.opensuse.org/90980400 > > > Diffs > ----- > > modules/ECMGenerateHeaders.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113406/diff/ > > > Testing > ------- > > Ported KParts and still everything works. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
