----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115632/#review49619 -----------------------------------------------------------
The reviewboardrc is fine. The applications patch is technically fine too, though as we port more applications to KF5 the question will arise whether we want the "default" KF5 build environment to include every possible application or not. Either way I'm not in a position to act as gatekeeper for KF5 purposes, devs like dfaure and ervin are better-placed. At this point I'm just ensuring that the script itself is technically suitable to the policy being set by the devs doing the work. kf5-applications-build-include <https://git.reviewboard.kde.org/r/115632/#comment34947> Would be better for these 2 modules to be a 'kde-projects'-based module-set. This allows kdesrc-build to automatically select the right branch (per the branch-group setting) if the kde-build-metadata is up to date (which seems to be the case now). Additionally it allows kdesrc-build to use dependency data in kde-build-metadata to ensure the right build order. Would look something like: module-set repository kde-projects use-modules kdevplatform kdevelop/kdevelop end module-set The "kdevelop/kdevelop" is just to disambiguate, otherwise kdesrc-build would pull in "kdevelop/*" for everything not ignored in kde-build-metadata/build-script-ignore. What is here is fine too, but if the appropriate branch for kdevelop ever changes that could lead to problems later, which is why I'm trying to push back toward branch-groups. - Michael Pyne On Feb. 10, 2014, 5:09 p.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115632/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2014, 5:09 p.m.) > > > Review request for Build System. > > > Repository: kdesrc-build > > > Description > ------- > > Two commits: > > Add .reviewboardrc > > Add frameworks-based kdevplatform + kdevelop > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > kf5-applications-build-include dab8498dfd5a5f6dd7a63d8d06d1701770760b33 > > Diff: https://git.reviewboard.kde.org/r/115632/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
