> On May 20, 2014, 4:15 p.m., Alex Merry wrote: > > Perhaps put some files in the test directories to make sure they are > > ignored?
Interestingly, I did put files in the test directories, but they were not added to this request.Maybe post-review decided it was not worth its time since the files were empty? :) Anyway, complete patch is here: http://agateau.com/tmp/0001-Skip-non-directory-files-inside-the-po-directory.patch - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118216/#review58198 ----------------------------------------------------------- On May 20, 2014, 3:05 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118216/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 3:05 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > I had a build failure today because I generated the catalog template (.pot > file) in the kwidgetsaddons repository and so had a po/kwidgetsaddons_qt5.pot > file. Build failed because it tried to find .po files in > "po/kwidgetsaddons_qt5.pot/" > > > Diffs > ----- > > modules/ECMPoQmTools.cmake e217dd3 > tests/ECMPoQmToolsTest/CMakeLists.txt 3dcb351 > > Diff: https://git.reviewboard.kde.org/r/118216/diff/ > > > Testing > ------- > > kwidgetsaddons now build even if I have a .pot file in there. Added a file to > be ignored to the po/ dir of the unit test. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
