----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118020/#review62470 -----------------------------------------------------------
kde-modules/KDEInstallDirs.cmake <https://git.reviewboard.kde.org/r/118020/#comment43366> This should actually be "METAINFODIR", to match the code below. kde-modules/KDEInstallDirs.cmake <https://git.reviewboard.kde.org/r/118020/#comment43367> The final argument (the old-style name) should not be included for new variables, as they don't need to keep compatibility with anything. - Alex Merry On July 15, 2014, 11:21 p.m., Matthias Klumpp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118020/ > ----------------------------------------------------------- > > (Updated July 15, 2014, 11:21 p.m.) > > > Review request for Extra Cmake Modules. > > > Repository: extra-cmake-modules > > > Description > ------- > > This patch adds XDG directory varaibles for AppStream upstream metadata > locations as described in > http://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent > (Section: Filesystem locations) > Now that more KDE projects started to ship that metadata, I think it makes > sense to add variables for it. > I don't care much about the name, so if you have a better idea, go for it ;-) > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake 90ed5b8 > tests/KDEInstallDirsTest/vars_defined/CMakeLists.txt 3940b81 > > Diff: https://git.reviewboard.kde.org/r/118020/diff/ > > > Testing > ------- > > > Thanks, > > Matthias Klumpp > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
