----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119339/#review62588 -----------------------------------------------------------
I don't have any objections with forward-porting the kdelibs commit to e-c-m, but thought it wasn't worth the effort since FindPyQt4.cmake is not part of any e-c-m release and it would make more sense to write a new version from scratch were we to move it out of `Attic/`. The forward-port doesn't hurt, though, so go ahead if you will. - Raphael Kubo da Costa On July 17, 2014, 5:54 p.m., Scott Kitterman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119339/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 5:54 p.m.) > > > Review request for Extra Cmake Modules, Alex Merry, Luca Beltrame, Raphael > Kubo da Costa, and Simon Edwards. > > > Repository: extra-cmake-modules > > > Description > ------- > > Since PyQt 4.10, PyQt.pyqtconfig is deprecated and not available unless PyQt > is built using the old configure script. > > There is no direct replacement for it, as PyQt's new build system does not > provide as much information as before by design. Luckily, most of the > variables we are interested in can be obtained from PyQt's QtCore module > itself even if its old build system is used. > > The only exception is pyqt_sip_dir, which cannot be determined at all if > pyqtconfig is not available. In this case, the most we can do is guess the > default path like QScintilla2 does, and fail if it does not exist. > The user then needs to specify it manually via CMake with something like > -DPYQT4_SIP_DIR=/usr/share/sip/PyQt4. To this effect, all variables set by > FindPyQt4.cmake have been made cache variables, which means their values can > be overriden by the user, thus ignoring the contents read via FindPyQt.py. > > This is identical to > http://commits.kde.org/kdelibs/a7e47438d4e3469dc9df70d613826cb360fc8d19 which > was review https://git.reviewboard.kde.org/r/119302/ . We should make the > same change in e-c-m prior to work to make the module work for either PyQt4 > or PyQt5. > > > Diffs > ----- > > > Diff: https://git.reviewboard.kde.org/r/119339/diff/ > > > Testing > ------- > > No additional testing done for this change, but it's identical to the kdelibs > change. > > > Thanks, > > Scott Kitterman > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
