----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120481/#review68626 -----------------------------------------------------------
Well, I have two different things in mind: first of all, I can see the point of simplification, I doubt that it will be interesting though to build KDE in the near (next 5y) future with X11/Wayland. Second, the X11 situation is normally abstracted by Qt, so there is nearly never a need to have X11 code on windows, we don't build most of the stuff. And third, it is easy to add a REQUIRED in the find_package line, because normally developers don't think twice (This is linux after all, why shouldn't it have X11?!???). This will likely produce some errors, although I am not sure how severe this will be. So I am not really for it, but I am also not against it. - Patrick Spendrin On Okt. 16, 2014, 6:48 nachm., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120481/ > ----------------------------------------------------------- > > (Updated Okt. 16, 2014, 6:48 nachm.) > > > Review request for Extra Cmake Modules, kdewin and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > ------- > > While the search is unlikely to succeed on Windows, having different > behaviour between the platforms (eg: find_package(Wayland REQUIRED) was > not fatal on Windows, even though Wayland_FOUND would always be FALSE) > is not ideal, and if someone did port them to Windows for some reason, > the find modules should support that. > > If applications actually want different behaviour between platforms > (like requiring a module on Unix, but not on Windows), they should > implement that logic themselves (since they will have to deal with > targets not being defined, etc, anyway). > > > Diffs > ----- > > find-modules/FindEGL.cmake f1962b9abc7fef381efe073c1ce18379ab2a47da > find-modules/FindWayland.cmake 11716f04444497db380e94b3d8ef69f41546f789 > find-modules/FindX11_XCB.cmake 05d18d5adfd197fea4f0c7defbe53da776ebac79 > find-modules/FindXCB.cmake 76d69fd790fb4831abd8a8351a684b97f6816081 > > Diff: https://git.reviewboard.kde.org/r/120481/diff/ > > > Testing > ------- > > None whatsoever, since I want Martin's feedback on the idea first. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
