----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121400/ -----------------------------------------------------------
(Updated Dec. 10, 2014, 8:57 p.m.) Review request for Build System and KDE Frameworks. Changes ------- Support an explicit VERSION parameter. When that parameter is not given, give an error if PROJECT_VERSION is not set. Repository: extra-cmake-modules Description (updated) ------- Windows has a way for executables and shared libraries (DLLs) to contain version information in a machine-readable format. This information can be seen in Explorer in the file properties (http://goo.gl/UbJGte) and also in the tooltip when hovering the file. It's also used by Windows Installer to avoid overwriting an existing DLL with an older version. Apart from the version number, this resource contains information like the "product name", "file description", "company name", and "copyright". While optional, if we're going to add a version resource, we might as well fill these in properly; why not? :) This change adds a CMake macro to generate a Windows resource script with version information passed to the macro. The macro documentation is a single line, obviously needs work. Diffs (updated) ----- modules/ECMVersionResource.rc.in PRE-CREATION modules/ECMCreateVersionResource.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121400/diff/ Testing ------- Tested with CMake 3.0.2 in kcoreaddons (review /r/121401), MSVC2013, Windows 7. Explorer tooltip shows description and version. File properties shows all the new information. Thanks, Nicolás Alvarez
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
