> On Dec. 28, 2014, 4:30 p.m., Hrvoje Senjan wrote: > > kde-modules/KDEInstallDirs.cmake, line 458 > > <https://git.reviewboard.kde.org/r/121646/diff/2/?file=335706#file335706line458> > > > > typo? should be uppercase, no?
Good spot, thanks! - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121646/#review72609 ----------------------------------------------------------- On Dec. 28, 2014, 3:45 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121646/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2014, 3:45 p.m.) > > > Review request for Extra Cmake Modules and Stephen Kelly. > > > Repository: extra-cmake-modules > > > Description > ------- > > Creating variables whose names start with CMAKE_ is a bad idea for > modules distributed outside CMake itself. Since the module is called > KDEInstallDirs, having a KDE_INSTALL_ prefix for the variables is clear > and intuitive. > > Both CMAKE_INSTALL_* variables and the older KDELibs4-compatible > variables are provided, unless KDE_INSTALL_DIRS_NO_DEPRECATED is set to > TRUE before the module is included. Even then, the CMAKE_INSTALL_* > variables provided by the GNUInstallDirs module will still be set and > understood (for compatibility with that module), unless > KDE_INSTALL_DIRS_NO_CMAKE_VARIABLES is set to TRUE. > > --- > > Refactor KDEInstallDirs tests. > > > Diffs > ----- > > kde-modules/KDEInstallDirs.cmake 46d3a5c69bf9b3bc548dd600484298cdf59a9fdf > tests/CMakeLists.txt 0ee544a55708991c48470299965eacba814e7452 > tests/KDEInstallDirsTest/not_cache_variable/CMakeLists.txt > ea62d95bea07f77917f2269b8b89d665a7f36ba5 > tests/KDEInstallDirsTest/qt_vars_defined/CMakeLists.txt > 910a0ede23e71a2562a8b75d40fa84dc4e31d2a1 > tests/KDEInstallDirsTest/qt_vars_defined/main.c > c13815cea825c1f1ea72190a7fe901cd1fa55d0d > tests/KDEInstallDirsTest/relative_or_absolute/CMakeLists.txt PRE-CREATION > tests/KDEInstallDirsTest/usr_vars_defined/CMakeLists.txt > aea07604c3c6d11e4ed09922dca528469717809c > tests/KDEInstallDirsTest/usr_vars_defined/main.c > tests/KDEInstallDirsTest/var_list.cmake PRE-CREATION > tests/KDEInstallDirsTest/vars_defined/CMakeLists.txt > ab46cee112dd95a72b2ff90c26d8415631602e1c > tests/KDEInstallDirsTest/vars_defined/main.c > tests/KDEInstallDirsTest/vars_in_sync/CMakeLists.txt PRE-CREATION > tests/test_helpers.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121646/diff/ > > > Testing > ------- > > `make test` passes. I will do a rebuild of frameworks soon. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
