----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121982/ -----------------------------------------------------------
Review request for Extra Cmake Modules and Kevin Kofler. Repository: extra-cmake-modules Description ------- Cache variables such as CMAKE_INSTALL_BINDIR may be used by other modules included from parallel parts of the tree, so we should not touch them. We still override them in the runtime environment, but this will not interfere with parallel subtrees of the project. As part of this, the order of precedence of variables specified on the command line is changed, so that KDE_INSTALL_* is considered first (although it is still considered "undefined" in the documentation). This means that if you only specify CMAKE_INSTALL_BINDIR, that will be used by both KDEInstallDirs and GNUInstallDirs, but if you specify both that and KDE_INSTALL_BINDIR, KDEInstallDirs will use KDE_INSTALL_BINDIR instead. This is probably not too useful, but seems more useful than any other arrangement. BUG: 342717 Diffs ----- kde-modules/KDEInstallDirs.cmake 7d592afcbfd87f08650428754da72e70a9b70155 Diff: https://git.reviewboard.kde.org/r/121982/diff/ Testing ------- `make test` - all tests pass. Kevin: can you please test this with Calamares? Thanks, Alex Merry
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
