----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121971/#review73974 -----------------------------------------------------------
Ship it! If it works with the oldest supported version of cmake, ship it ;) - David Faure On Jan. 10, 2015, 5:19 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121971/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2015, 5:19 p.m.) > > > Review request for Extra Cmake Modules and David Faure. > > > Repository: extra-cmake-modules > > > Description > ------- > > With CMake 3.1, @-style variable expansion is deprecated outside of > configure_file() or string(CONFIGURE) contexts (CMP0053). This causes > ecm_generate_pri_file() to produce dev warnings with this verison of > CMake, and would break this function in projects that set CMake 3.1 as > their required version. > > > Diffs > ----- > > modules/ECMGeneratePriFile.cmake b353e867586346a10e0f8df77b81ff83993ae497 > > Diff: https://git.reviewboard.kde.org/r/121971/diff/ > > > Testing > ------- > > Attica still configures and builds, and produces the same .pri file it did > before. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
