----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121545/#review74043 -----------------------------------------------------------
toolchain/Android.cmake <https://git.reviewboard.kde.org/r/121545/#comment51414> Please mention this in the documentation. Can you make the changelog more descriptive? Maybe something like "New Android toolchain support module" or "New android toolchain file". "New android support" sounds like the existing modules were updated to support Android, or something. - Alex Merry On Jan. 14, 2015, 1:23 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121545/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2015, 1:23 a.m.) > > > Review request for Build System. > > > Repository: extra-cmake-modules > > > Description > ------- > > Introduces the new Android toolchain file for being able to easily compile > our cmake projects in Android, with an emphasis on Qt projects. > > CHANGELOG: New Android support. > > > Diffs > ----- > > CMakeLists.txt b230bb2 > toolchain/Android.cmake PRE-CREATION > toolchain/deployment-file.json.in PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121545/diff/ > > > Testing > ------- > > I've built KAlgebra with this, as well as some other test applications. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
