> On Jan. 19, 2015, 10:56 p.m., Jeremy Whiting wrote: > > It mostly works here. For some reason it's not adding the .icns filename to > > the Info.plist here. I tried also adding that file manually to Info.plist > > like I see it in klettres.app which is still using the old kde4 > > add_app_icon macro which is working and it's still not showing the icon in > > Finder here. I pushed my use of this to kanagram's appicon branch to try it > > on windows some time also, or for you to tell me how I'm using the macro > > wrong possibly.
It looks like kde4_add_app_icon in KDELibs4Support is doing something completely different - it's converting the 128px icon to a tiff file, then converting that to an icns file. Not sure if that makes a difference. The issue with not being added to the Info.plist, though, is a variable scope issue. I'll fix that momentarily. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122135/#review74362 ----------------------------------------------------------- On Jan. 19, 2015, 10:01 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122135/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2015, 10:01 p.m.) > > > Review request for Extra Cmake Modules, Ralf Habacker and Jeremy Whiting. > > > Repository: extra-cmake-modules > > > Description > ------- > > This adds an application icon to an executable from PNG files for > Windows and Mac OS X. Unlike the similar kde4_add_app_icon macro from > kdelibs, this requires icons to be explicitly listed as arguments > (meaning CMake can tell when ones are added or deleted and reconfigure > as appropriate), and it works with Matthias Benkmann's png2ico tool, as > well as the KDE-Win tool of the same name. > > Currently missing unit tests. Also completely untested (except that > `make test` runs on Linux, so there are no obvious syntax errors). > > With thanks to Ralf Habacker for the initial work on porting > kde4_add_app_icon. > > CHANGELOG: Add ECMAddAppIcon module to add icons to executable targets > on Windows and Mac OS X. > > > Diffs > ----- > > docs/find-module/FindPng2Ico.rst PRE-CREATION > docs/module/ECMAddAppIcon.rst PRE-CREATION > find-modules/FindPng2Ico.cmake PRE-CREATION > modules/ECMAddAppIcon.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122135/diff/ > > > Testing > ------- > > `make test` passes, which just provides a very basic check for syntax errors. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
