----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122193/#review75015 -----------------------------------------------------------
Aha, am not the only one with a patch about "Various projects use various naming conventions, so supporting only lowercase.h headers in ECMGenerateHeaders is a bit limiting" :) Just that my case are CamelCase.h headers, see https://git.reviewboard.kde.org/r/122317/ No idea yet how these two patches could be aligned, but ideally they would. Will think about some more next week. - Friedrich W. H. Kossebau On Jan. 21, 2015, 9:25 nachm., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122193/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:25 nachm.) > > > Review request for Build System. > > > Repository: extra-cmake-modules > > > Description > ------- > > Various projects use various naming conventions, so supporting only > lowercase.h headers in ECMGenerateHeaders is a bit limiting :) This patch > adds a fallback which will try to look for lower-case.h header file in case > lowercase.h does not exist. > > > Diffs > ----- > > modules/ECMGenerateHeaders.cmake bac5086 > tests/ECMGenerateHeadersTest/run_test.cmake.config 0a2425f > > Diff: https://git.reviewboard.kde.org/r/122193/diff/ > > > Testing > ------- > > Added a unit-test which seems to pass. > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Kde-buildsystem mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-buildsystem
